Skip to content

NO JIRA: Skip reopening Jira when GitHub issue has linked PR#13

Closed
dlaw4608 wants to merge 1 commit into
mainfrom
linked_PR
Closed

NO JIRA: Skip reopening Jira when GitHub issue has linked PR#13
dlaw4608 wants to merge 1 commit into
mainfrom
linked_PR

Conversation

@dlaw4608
Copy link
Copy Markdown

@dlaw4608 dlaw4608 commented May 27, 2026 •
edited
Loading

Previously ghira would reopen any manually closed Jira ticket if the GitHub
issue was still open. This broke the workflow where development
tickets are closed once a PR is created to avoid "waiting for review" items
cluttering sprints.

Now queries GitHub's timeline API before reopening. If the issue
has a linked PR, leaves the Jira ticket closed.

Verified locally :
2026/05/27 10:17:42 Issue 669 has a linked PR, skipping reopen of Jira ticket OSASINFRA-4133

@dlaw4608
Skip reopening Jira when GitHub issue has linked PR
b71e6b8 
  Check GitHub timeline API for linked PRs before reopening closed
  Jira tickets. This allows tickets to stay closed during PR review,
  preventing review-waiting items from spilling across sprints.

  NO JIRA

Signed-off-by: Daniel Lawton <dlawton@redhat.com>
@openshift-ci openshift-ci Bot requested review from eshulman2 and gryf May 27, 2026 10:27
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dlaw4608
Once this PR has been reviewed and has the lgtm label, please assign stephenfin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dlaw4608 dlaw4608 requested a review from mandre May 27, 2026 10:27
@dlaw4608 dlaw4608 self-assigned this May 27, 2026
@mandre
Copy link
Copy Markdown
Contributor

mandre commented Jun 3, 2026

Hi Daniel, perhaps what should had been brought into the sprint (for feature work) wasn't the card that was mirrored from github, but instead a child card that focused on creating a PR?

@dlaw4608
Copy link
Copy Markdown
Author

dlaw4608 commented Jun 3, 2026

Hey Martin, using child items would be a more straightforward solution. Thanks for that 👍
So in that case, I will go ahead and close this PR as it is not really needed.

@dlaw4608 dlaw4608 closed this Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eshulman2 eshulman2 Awaiting requested review from eshulman2

@gryf gryf Awaiting requested review from gryf

@mandre mandre Awaiting requested review from mandre

Assignees

@dlaw4608 dlaw4608

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dlaw4608 @mandre